diff options
| author |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2018-05-02 11:38:31 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-05-06 19:06:13 +0900 |
| commit | dde74d732fc3c5fa4bc4238aa935c164ff6c2dd5 (patch) | |
| tree | c7e34c96fdafe12f71109b8730da4e1bad874cb6 /config.c | |
| parent | test-tool: help verifying BUG() code paths (diff) | |
| download | tgif-dde74d732fc3c5fa4bc4238aa935c164ff6c2dd5.tar.xz | |
run-command: use BUG() to report bugs, not die()
The slightly misleading name die_bug() of the function intended to
report a bug is actually called always, and only reports a bug if the
passed-in parameter `err` is non-zero.
It uses die_errno() to report the bug, to helpfully include the error
message corresponding to `err`.
However, as these messages indicate bugs, we really should use BUG().
And as BUG() is a macro to be able to report the exact file and line
number, we need to convert die_bug() to a macro instead of only
replacing the die_errno() by a call to BUG().
While at it, use a name more indicative of the purpose: CHECK_BUG().
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'config.c')
0 files changed, 0 insertions, 0 deletions