summaryrefslogtreecommitdiff
path: root/compat
diff options
context:
space:
mode:
authorLibravatar Patrick Reynolds <patrick.reynolds@github.com>2014-09-18 11:57:09 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-09-18 10:38:49 -0700
commit7559a1be8a0afb10df41d25e4cf4c5285a5faef1 (patch)
treee4386761ad9e73a7e6c4622743adcf24912eb5eb /compat
parentMerge git://github.com/git-l10n/git-po (diff)
downloadtgif-7559a1be8a0afb10df41d25e4cf4c5285a5faef1.tar.xz
unblock and unignore SIGPIPE
Blocked and ignored signals -- but not caught signals -- are inherited across exec. Some callers with sloppy signal-handling behavior can call git with SIGPIPE blocked or ignored, even non-deterministically. When SIGPIPE is blocked or ignored, several git commands can run indefinitely, ignoring EPIPE returns from write() calls, even when the process that called them has gone away. Our specific case involved a pipe of git diff-tree output to a script that reads a limited amount of diff data. In an ideal world, git would never be called with SIGPIPE blocked or ignored. But in the real world, several real potential callers, including Perl, Apache, and Unicorn, sometimes spawn subprocesses with SIGPIPE ignored. It is easier and more productive to harden git against this mistake than to clean it up in every potential parent process. Signed-off-by: Patrick Reynolds <patrick.reynolds@github.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat')
0 files changed, 0 insertions, 0 deletions