summaryrefslogtreecommitdiff
path: root/compat/obstack.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2015-09-24 17:07:00 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-09-25 10:18:18 -0700
commitb7115a350b5c01ce0ae7a8735e4235d4b2367b5f (patch)
treec61ee7939864a8d3a82abcc26fe803851599f0f4 /compat/obstack.c
parenthttp-push: replace strcat with xsnprintf (diff)
downloadtgif-b7115a350b5c01ce0ae7a8735e4235d4b2367b5f.tar.xz
receive-pack: convert strncpy to xsnprintf
This strncpy is pointless; we pass the strlen() of the src string, meaning that it works just like a memcpy. Worse, though, is that the size has no relation to the destination buffer, meaning it is a potential overflow. In practice, it's not. We pass only short constant strings like "warning: " and "error: ", which are much smaller than the destination buffer. We can make this much simpler by just using xsnprintf, which will check for overflow and return the size for our next vsnprintf, without us having to run a separate strlen(). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat/obstack.c')
0 files changed, 0 insertions, 0 deletions