summaryrefslogtreecommitdiff
path: root/compat/nedmalloc
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2016-06-20 17:14:14 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-06-20 15:08:07 -0700
commitbab748371a104c58058c0eff9f4073b710ce0355 (patch)
treed4e86d14b8944617db1a2253eaefd6b7ab40bba5 /compat/nedmalloc
parentt0006: test various date formats (diff)
downloadtgif-bab748371a104c58058c0eff9f4073b710ce0355.tar.xz
local_tzoffset: detect errors from tm_to_time_t
When we want to know the local timezone offset at a given timestamp, we compute it by asking for localtime() at the given time, and comparing the offset to GMT at that time. However, there's some juggling between time_t and "struct tm" which happens, which involves calling our own tm_to_time_t(). If that function returns an error (e.g., because it only handles dates up to the year 2099), it returns "-1", which we treat as a time_t, and is clearly bogus, leading to bizarre timestamps (that seem to always adjust the time back to (time_t)(uint32_t)-1, in the year 2106). It's not a good idea for local_tzoffset() to simply die here; it would make it hard to run "git log" on a repository with funny timestamps. Instead, let's just treat such cases as "zero offset". Reported-by: Norbert Kiesel <nkiesel@gmail.com> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat/nedmalloc')
0 files changed, 0 insertions, 0 deletions