diff options
author | Jeff King <peff@peff.net> | 2021-09-11 11:01:16 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-09-12 16:25:23 -0700 |
commit | 8d133a4653abed4b06d3deb8bd71cf55cd87c990 (patch) | |
tree | 8ad243c544a170cf5d3c30ec80105ae2cdc5e699 /common-main.c | |
parent | Git 2.33 (diff) | |
download | tgif-8d133a4653abed4b06d3deb8bd71cf55cd87c990.tar.xz |
strvec: use size_t to store nr and alloc
We converted argv_array (which later became strvec) to use size_t in
819f0e76b1 (argv-array: use size_t for count and alloc, 2020-07-28) in
order to avoid the possibility of integer overflow. But later, commit
d70a9eb611 (strvec: rename struct fields, 2020-07-28) accidentally
converted these back to ints!
Those two commits were part of the same patch series. I'm pretty sure
what happened is that they were originally written in the opposite order
and then cleaned up and re-ordered during an interactive rebase. And
when resolving the inevitable conflict, I mistakenly took the "rename"
patch completely, accidentally dropping the type change.
We can correct it now; better late than never.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'common-main.c')
0 files changed, 0 insertions, 0 deletions