diff options
author | SZEDER Gábor <szeder.dev@gmail.com> | 2019-10-21 18:00:42 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-10-23 12:53:51 +0900 |
commit | c72fc40d0904cbf3199258c2f471c2351e024b1e (patch) | |
tree | f5a673af242d74fe738ee6dd0318e343e5eb7ce8 /commit.c | |
parent | path.c: mark 'logs/HEAD' in 'common_list' as file (diff) | |
download | tgif-c72fc40d0904cbf3199258c2f471c2351e024b1e.tar.xz |
path.c: clarify two field names in 'struct common_dir'
An array of 'struct common_dir' instances is used to specify whether
various paths in $GIT_DIR are specific to a worktree, or are common,
i.e. belong to main worktree. The names of two fields in this
struct are somewhat confusing or ambigious:
- The path is recorded in the struct's 'dirname' field, even though
several entries are regular files e.g. 'gc.pid', 'packed-refs',
etc.
Rename this field to 'path' to reduce confusion.
- The field 'exclude' tells whether the path is excluded... from
where? Excluded from the common dir or from the worktree? It
means the former, but it's ambigious.
Rename this field to 'is_common' to make it unambigious what it
means. This, however, means the exact opposite of what 'exclude'
meant, so we have to negate the field's value in all entries as
well.
The diff is best viewed with '--color-words'.
Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
0 files changed, 0 insertions, 0 deletions