diff options
author | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-04-24 14:31:57 -0700 |
---|---|---|
committer | Linus Torvalds <torvalds@ppc970.osdl.org> | 2005-04-24 14:31:57 -0700 |
commit | 235ac40772e259adfd978850b56192dca9791bb8 (patch) | |
tree | f74ed93cd9e524e798eb06ad59df494ce866ebc9 /commit.c | |
parent | Verify that the object type matches for tree/commit objects even before parsing. (diff) | |
download | tgif-235ac40772e259adfd978850b56192dca9791bb8.tar.xz |
Don't add references to objects we couldn't find.
That would SIGSEGV.
Diffstat (limited to 'commit.c')
-rw-r--r-- | commit.c | 9 |
1 files changed, 6 insertions, 3 deletions
@@ -59,13 +59,16 @@ int parse_commit(struct commit *item) sha1_to_hex(item->object.sha1)); get_sha1_hex(bufptr + 5, parent); item->tree = lookup_tree(parent); - add_ref(&item->object, &item->tree->object); + if (item->tree) + add_ref(&item->object, &item->tree->object); bufptr += 46; /* "tree " + "hex sha1" + "\n" */ while (!memcmp(bufptr, "parent ", 7) && !get_sha1_hex(bufptr + 7, parent)) { struct commit *new_parent = lookup_commit(parent); - commit_list_insert(new_parent, &item->parents); - add_ref(&item->object, &new_parent->object); + if (new_parent) { + commit_list_insert(new_parent, &item->parents); + add_ref(&item->object, &new_parent->object); + } bufptr += 48; } item->date = parse_commit_date(bufptr); |