summaryrefslogtreecommitdiff
path: root/commit.c
diff options
context:
space:
mode:
authorLibravatar Linus Torvalds <torvalds@ppc970.osdl.org>2005-04-24 14:31:57 -0700
committerLibravatar Linus Torvalds <torvalds@ppc970.osdl.org>2005-04-24 14:31:57 -0700
commit235ac40772e259adfd978850b56192dca9791bb8 (patch)
treef74ed93cd9e524e798eb06ad59df494ce866ebc9 /commit.c
parentVerify that the object type matches for tree/commit objects even before parsing. (diff)
downloadtgif-235ac40772e259adfd978850b56192dca9791bb8.tar.xz
Don't add references to objects we couldn't find.
That would SIGSEGV.
Diffstat (limited to 'commit.c')
-rw-r--r--commit.c9
1 files changed, 6 insertions, 3 deletions
diff --git a/commit.c b/commit.c
index c6fdfd4919..9fbcbd33c7 100644
--- a/commit.c
+++ b/commit.c
@@ -59,13 +59,16 @@ int parse_commit(struct commit *item)
sha1_to_hex(item->object.sha1));
get_sha1_hex(bufptr + 5, parent);
item->tree = lookup_tree(parent);
- add_ref(&item->object, &item->tree->object);
+ if (item->tree)
+ add_ref(&item->object, &item->tree->object);
bufptr += 46; /* "tree " + "hex sha1" + "\n" */
while (!memcmp(bufptr, "parent ", 7) &&
!get_sha1_hex(bufptr + 7, parent)) {
struct commit *new_parent = lookup_commit(parent);
- commit_list_insert(new_parent, &item->parents);
- add_ref(&item->object, &new_parent->object);
+ if (new_parent) {
+ commit_list_insert(new_parent, &item->parents);
+ add_ref(&item->object, &new_parent->object);
+ }
bufptr += 48;
}
item->date = parse_commit_date(bufptr);