summaryrefslogtreecommitdiff
path: root/commit.c
diff options
context:
space:
mode:
authorLibravatar Derrick Stolee <dstolee@microsoft.com>2018-08-21 20:54:12 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2018-08-21 14:08:18 -0700
commit1820703045f8974bc5320d08a3611f4e29c83bf9 (patch)
tree17b92e3c3a3a33f3bcb13eefdc8f2fb04876e2f2 /commit.c
parentname-rev: change a "long" variable to timestamp_t (diff)
downloadtgif-1820703045f8974bc5320d08a3611f4e29c83bf9.tar.xz
commit: use timestamp_t for author_date_slab
The author_date_slab is used to store the author date of a commit when walking with the --author-date flag in rev-list or log. This was added as an 'unsigned long' in 81c6b38b "log: --author-date-order" Since 'unsigned long' is ambiguous in its bit-ness across platforms (64-bit in Linux, 32-bit in Windows, for example), most references to the author dates in commit.c were converted to timestamp_t in dddbad72 "timestamp_t: a new data type for timestamps" However, the slab definition was missed, leading to a mismatch in the data types in Windows. This would not reveal itself as a bug unless someone authors a commit after February 2106, but commits can store anything as their author date. Signed-off-by: Derrick Stolee <dstolee@microsoft.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit.c')
-rw-r--r--commit.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/commit.c b/commit.c
index 99a62b90ee..801b6dc11f 100644
--- a/commit.c
+++ b/commit.c
@@ -588,7 +588,7 @@ struct commit *pop_commit(struct commit_list **stack)
define_commit_slab(indegree_slab, int);
/* record author-date for each commit object */
-define_commit_slab(author_date_slab, unsigned long);
+define_commit_slab(author_date_slab, timestamp_t);
static void record_author_date(struct author_date_slab *author_date,
struct commit *commit)