diff options
author | Taylor Blau <me@ttaylorr.com> | 2020-04-30 13:48:57 -0600 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-04-30 14:19:13 -0700 |
commit | cac4b8e22ee39e52341d718450f8e4055c4dc16f (patch) | |
tree | a9f706e5504f65230a96e94fa8f320b518455a07 /ci/util | |
parent | shallow.h: document '{commit,rollback}_shallow_file' (diff) | |
download | tgif-cac4b8e22ee39e52341d718450f8e4055c4dc16f.tar.xz |
shallow: use struct 'shallow_lock' for additional safety
In previous patches, the functions 'commit_shallow_file' and
'rollback_shallow_file' were introduced to reset the shallowness
validity checks on a repository after potentially modifying
'.git/shallow'.
These functions can be made safer by wrapping the 'struct lockfile *' in
a new type, 'shallow_lock', so that they cannot be called with a raw
lock (and potentially misused by other code that happens to possess a
lockfile, but has nothing to do with shallowness).
This patch introduces that type as a thin wrapper around 'struct
lockfile', and updates the two aforementioned functions and their
callers to use it.
Suggested-by: Junio C Hamano <gitster@pobox.com>
Helped-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ci/util')
0 files changed, 0 insertions, 0 deletions