diff options
author | Taylor Blau <me@ttaylorr.com> | 2020-09-18 09:27:27 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2020-09-18 10:35:39 -0700 |
commit | 809e0327f579267ea78a1b2f727d3b63c1f5d044 (patch) | |
tree | 4881730cb7cdf45c8bd2c45a505fd3cbadf6e3df /ci/util | |
parent | commit-graph: rename 'split_commit_graph_opts' (diff) | |
download | tgif-809e0327f579267ea78a1b2f727d3b63c1f5d044.tar.xz |
builtin/commit-graph.c: introduce '--max-new-filters=<n>'
Introduce a command-line flag to specify the maximum number of new Bloom
filters that a 'git commit-graph write' is willing to compute from
scratch.
Prior to this patch, a commit-graph write with '--changed-paths' would
compute Bloom filters for all selected commits which haven't already
been computed (i.e., by a previous commit-graph write with '--split'
such that a roll-up or replacement is performed).
This behavior can cause prohibitively-long commit-graph writes for a
variety of reasons:
* There may be lots of filters whose diffs take a long time to
generate (for example, they have close to the maximum number of
changes, diffing itself takes a long time, etc).
* Old-style commit-graphs (which encode filters with too many entries
as not having been computed at all) cause us to waste time
recomputing filters that appear to have not been computed only to
discover that they are too-large.
This can make the upper-bound of the time it takes for 'git commit-graph
write --changed-paths' to be rather unpredictable.
To make this command behave more predictably, introduce
'--max-new-filters=<n>' to allow computing at most '<n>' Bloom filters
from scratch. This lets "computing" already-known filters proceed
quickly, while bounding the number of slow tasks that Git is willing to
do.
Helped-by: Junio C Hamano <gitster@pobox.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'ci/util')
0 files changed, 0 insertions, 0 deletions