diff options
author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2019-06-28 16:35:28 +0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2019-06-28 09:32:23 -0700 |
commit | 663d25018f11418ed888128e8b07b1cbe576712a (patch) | |
tree | 2970085ad81eaf13a52a9dbf10a84e7325c1e9e2 /cache.h | |
parent | Use the right 'struct repository' instead of the_repository (diff) | |
download | tgif-663d25018f11418ed888128e8b07b1cbe576712a.tar.xz |
t7814: do not generate same commits in different repos
t7814 has repo tree like this
initial-repo
submodule
sub
In each repo 'submodule' and 'sub', a commit is made to add the same
initial file 'a' with the same message 'add a'. If tests run fast
enough, the two commits are made in the same second, resulting
identical commits.
There is nothing wrong with that per-se. But it could make the test
flaky. Currently all submodule odbs are merged back in the main
one (because we can't, or couldn't, access separate submodule repos
otherwise). But eventually we need to access objects from the right
repo.
Because the same commit could sometimes be present in both 'submodule'
and 'sub', if there is a bug looking up objects in the wrong repo,
sometimes it will go unnoticed because it finds the needed object in the
wrong repo anyway.
Fix this by changing commit time after every commit. This makes all
commits unique. Of course there are still identical blobs in different
repos, but because we often lookup commit first, then tree and blob,
unique commits are already quite safe.
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'cache.h')
0 files changed, 0 insertions, 0 deletions