diff options
| author |  Jay Soffian <jaysoffian@gmail.com> | 2010-08-26 17:34:29 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2010-08-26 16:42:25 -0700 |
| commit | ea16a030aaaaebb3d0038e3ec2d9cd837985dee0 (patch) | |
| tree | 16a834ed395a18a402613d93ccbfa17d074386c4 /builtin | |
| parent | tree-walk: Correct bitrotted comment about tree_entry() (diff) | |
| download | tgif-ea16a030aaaaebb3d0038e3ec2d9cd837985dee0.tar.xz | |
for-each-ref: fix objectname:short bug
When objectname:short was introduced, it forgot to copy the result of
find_unique_abbrev. Because the result of find_unique_abbrev is a
pointer to static buffer, this resulted in the same value being
substituted in for each ref.
Signed-off-by: Jay Soffian <jaysoffian@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/for-each-ref.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c index a2b28c6962..89e75c6894 100644 --- a/builtin/for-each-ref.c +++ b/builtin/for-each-ref.c @@ -228,7 +228,8 @@ static void grab_common_values(struct atom_value *val, int deref, struct object v->s = s; } else if (!strcmp(name, "objectname:short")) { - v->s = find_unique_abbrev(obj->sha1, DEFAULT_ABBREV); + v->s = xstrdup(find_unique_abbrev(obj->sha1, + DEFAULT_ABBREV)); } } } |