diff options
author | Junio C Hamano <gitster@pobox.com> | 2017-04-11 00:21:51 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-04-11 00:21:51 -0700 |
commit | d9758cf81cd8af42a7ab55dc3c1a889d9ddd3f81 (patch) | |
tree | adf2a41ed8873a16e8f14dc9845a0ba840ccf8b0 /builtin | |
parent | Merge branch 'ab/ref-filter-no-contains' (diff) | |
parent | log: if --decorate is not given, default to --decorate=auto (diff) | |
download | tgif-d9758cf81cd8af42a7ab55dc3c1a889d9ddd3f81.tar.xz |
Merge branch 'ah/log-decorate-default-to-auto'
The default behaviour of "git log" in an interactive session has
been changed to enable "--decorate".
* ah/log-decorate-default-to-auto:
log: if --decorate is not given, default to --decorate=auto
Diffstat (limited to 'builtin')
-rw-r--r-- | builtin/log.c | 9 |
1 files changed, 8 insertions, 1 deletions
diff --git a/builtin/log.c b/builtin/log.c index 670229cbb4..b3b10cc1ed 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -52,6 +52,11 @@ struct line_opt_callback_data { struct string_list args; }; +static int auto_decoration_style(void) +{ + return (isatty(1) || pager_in_use()) ? DECORATE_SHORT_REFS : 0; +} + static int parse_decoration_style(const char *var, const char *value) { switch (git_config_maybe_bool(var, value)) { @@ -67,7 +72,7 @@ static int parse_decoration_style(const char *var, const char *value) else if (!strcmp(value, "short")) return DECORATE_SHORT_REFS; else if (!strcmp(value, "auto")) - return (isatty(1) || pager_in_use()) ? DECORATE_SHORT_REFS : 0; + return auto_decoration_style(); return -1; } @@ -405,6 +410,8 @@ static int git_log_config(const char *var, const char *value, void *cb) if (decoration_style < 0) decoration_style = 0; /* maybe warn? */ return 0; + } else { + decoration_style = auto_decoration_style(); } if (!strcmp(var, "log.showroot")) { default_show_root = git_config_bool(var, value); |