summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Sebastian Schuberth <sschuberth@gmail.com>2014-01-02 17:17:11 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-01-06 11:26:31 -0800
commitc6127fa3e25551e969d775b0332d37dc84db1969 (patch)
tree7c154b0d3fc8e7a4bd9a19b8cc185297b68b3972 /builtin
parentbuiltin/help.c: call load_command_list() only when it is needed (diff)
downloadtgif-c6127fa3e25551e969d775b0332d37dc84db1969.tar.xz
builtin/help.c: speed up is_git_command() by checking for builtin commands first
Since 2dce956 is_git_command() is a bit slow as it does file I/O in the call to list_commands_in_dir(). Avoid the file I/O by adding an early check for the builtin commands. Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/help.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/builtin/help.c b/builtin/help.c
index b6fc15e5b0..1fdefeb686 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -288,6 +288,9 @@ static struct cmdnames main_cmds, other_cmds;
static int is_git_command(const char *s)
{
+ if (is_builtin(s))
+ return 1;
+
load_command_list("git-", &main_cmds, &other_cmds);
return is_in_cmdlist(&main_cmds, s) ||
is_in_cmdlist(&other_cmds, s);