summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Elijah Newren <newren@gmail.com>2021-09-27 16:33:39 +0000
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-09-27 13:38:37 -0700
commitc512d27e787e9eb325731ab6aa7ac126f8cf6126 (patch)
tree2d07b5058c40a43be661004080406769e728a0f5 /builtin
parentt2500: add various tests for nuking untracked files (diff)
downloadtgif-c512d27e787e9eb325731ab6aa7ac126f8cf6126.tar.xz
checkout, read-tree: fix leak of unpack_trees_options.dir
Signed-off-by: Elijah Newren <newren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/checkout.c4
-rw-r--r--builtin/read-tree.c5
2 files changed, 9 insertions, 0 deletions
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 8c69dcdf72..5335435d61 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -760,6 +760,10 @@ static int merge_working_tree(const struct checkout_opts *opts,
init_tree_desc(&trees[1], tree->buffer, tree->size);
ret = unpack_trees(2, trees, &topts);
+ if (topts.dir) {
+ dir_clear(topts.dir);
+ FREE_AND_NULL(topts.dir);
+ }
clear_unpack_trees_porcelain(&topts);
if (ret == -1) {
/*
diff --git a/builtin/read-tree.c b/builtin/read-tree.c
index 485e7b0479..96102c222b 100644
--- a/builtin/read-tree.c
+++ b/builtin/read-tree.c
@@ -250,6 +250,11 @@ int cmd_read_tree(int argc, const char **argv, const char *cmd_prefix)
if (unpack_trees(nr_trees, t, &opts))
return 128;
+ if (opts.dir) {
+ dir_clear(opts.dir);
+ FREE_AND_NULL(opts.dir);
+ }
+
if (opts.debug_unpack || opts.dry_run)
return 0; /* do not write the index out */