summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Ben Wijen <ben@wijen.net>2019-08-30 17:16:06 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-09-07 10:17:05 -0700
commitbf1e28e0ad9b1d0d04203ebc43b9008de1969503 (patch)
treee8dc71da2dfa78097a089fe935b62aa472463e9f /builtin
parentbuiltin/rebase.c: make sure the active branch isn't moved when autostashing (diff)
downloadtgif-bf1e28e0ad9b1d0d04203ebc43b9008de1969503.tar.xz
builtin/rebase.c: Remove pointless message
When doing 'git rebase --autostash <upstream> <master>' with a dirty worktree a 'HEAD is now at ...' message is emitted, which is pointless as it refers to the old active branch which isn't actually moved. This commit removes the 'HEAD is now at...' message. Signed-off-by: Ben Wijen <ben@wijen.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/rebase.c16
1 files changed, 1 insertions, 15 deletions
diff --git a/builtin/rebase.c b/builtin/rebase.c
index 0a2f9273ee..118205e481 100644
--- a/builtin/rebase.c
+++ b/builtin/rebase.c
@@ -1968,12 +1968,6 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
state_dir_path("autostash", &options);
struct child_process stash = CHILD_PROCESS_INIT;
struct object_id oid;
- struct object_id head_oid;
- struct commit *head;
-
- if (get_oid("HEAD", &head_oid))
- die(_("could not determine HEAD revision"));
- head = lookup_commit_reference(the_repository, &head_oid);
argv_array_pushl(&stash.args,
"stash", "create", "autostash", NULL);
@@ -1994,17 +1988,9 @@ int cmd_rebase(int argc, const char **argv, const char *prefix)
options.state_dir);
write_file(autostash, "%s", oid_to_hex(&oid));
printf(_("Created autostash: %s\n"), buf.buf);
- if (reset_head(&head->object.oid, "reset --hard",
+ if (reset_head(NULL, "reset --hard",
NULL, RESET_HEAD_HARD, NULL, NULL) < 0)
die(_("could not reset --hard"));
- printf(_("HEAD is now at %s"),
- find_unique_abbrev(&head->object.oid,
- DEFAULT_ABBREV));
- strbuf_reset(&buf);
- pp_commit_easy(CMIT_FMT_ONELINE, head, &buf);
- if (buf.len > 0)
- printf(" %s", buf.buf);
- putchar('\n');
if (discard_index(the_repository->index) < 0 ||
repo_read_index(the_repository) < 0)