diff options
| author |  Ronnie Sahlberg <sahlberg@google.com> | 2014-04-16 15:26:44 -0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-09-03 10:04:07 -0700 |
| commit | b416af5bcdca3ac8426220f09efbfca2f1bec6e0 (patch) | |
| tree | 6a400b374ec600c38bdf039443a788f75720d147 /builtin | |
| parent | refs.c: change ref_transaction_update() to do error checking and return status (diff) | |
| download | tgif-b416af5bcdca3ac8426220f09efbfca2f1bec6e0.tar.xz | |
refs.c: change ref_transaction_create to do error checking and return status
Do basic error checking in ref_transaction_create() and make it return
non-zero on error. Update all callers to check the result of
ref_transaction_create(). There are currently no conditions in _create that
will return error but there will be in the future. Add an err argument that
will be updated on failure.
Signed-off-by: Ronnie Sahlberg <sahlberg@google.com>
Reviewed-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/update-ref.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/update-ref.c b/builtin/update-ref.c index 3067b11310..41121fa37b 100644 --- a/builtin/update-ref.c +++ b/builtin/update-ref.c @@ -226,7 +226,9 @@ static const char *parse_cmd_create(struct strbuf *input, const char *next) if (*next != line_termination) die("create %s: extra input: %s", refname, next); - ref_transaction_create(transaction, refname, new_sha1, update_flags); + if (ref_transaction_create(transaction, refname, new_sha1, + update_flags, &err)) + die("%s", err.buf); update_flags = 0; free(refname); |