diff options
| author |  Jeff King <peff@peff.net> | 2015-08-20 10:49:45 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2015-08-20 13:16:50 -0700 |
| commit | a92330d21c13cf244d8045f5c9d1df6e63893d58 (patch) | |
| tree | 5498d804f7f465b9e6240059166e97ae29fa51e9 /builtin | |
| parent | format_config: simplify buffer handling (diff) | |
| download | tgif-a92330d21c13cf244d8045f5c9d1df6e63893d58.tar.xz | |
get_urlmatch: avoid useless strbuf write
We create a strbuf only to insert a single string, pass the
resulting buffer to a function (which does not modify the
string), and then free it. We can just pass the original
string instead.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/config.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/builtin/config.c b/builtin/config.c index 04befce5b7..71acc44143 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -425,14 +425,11 @@ static int get_urlmatch(const char *var, const char *url) for_each_string_list_item(item, &values) { struct urlmatch_current_candidate_value *matched = item->util; - struct strbuf key = STRBUF_INIT; struct strbuf buf = STRBUF_INIT; - strbuf_addstr(&key, item->string); - format_config(&buf, key.buf, + format_config(&buf, item->string, matched->value_is_null ? NULL : matched->value.buf); fwrite(buf.buf, 1, buf.len, stdout); - strbuf_release(&key); strbuf_release(&buf); strbuf_release(&matched->value); |