diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-10-22 10:55:39 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2021-10-23 10:45:25 -0700 |
commit | a2fb7672c03eef86b8dbf33699c12307d504a299 (patch) | |
tree | 87b1b3e4f365979304468e135e36f999f3bcfcbd /builtin | |
parent | The fourteenth batch (diff) | |
download | tgif-a2fb7672c03eef86b8dbf33699c12307d504a299.tar.xz |
grep: prefer "struct grep_opt" over its "void *" equivalent
Stylistically fix up code added in bfac23d9534 (grep: Fix two memory
leaks, 2010-01-30). We usually don't use the "arg" at all once we've
casted it to the struct we want, let's not do that here when we're
freeing it. Perhaps it was thought that a cast to "void *" would
otherwise be needed?
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r-- | builtin/grep.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/grep.c b/builtin/grep.c index 8af5249a7b..fd184c182a 100644 --- a/builtin/grep.c +++ b/builtin/grep.c @@ -199,8 +199,8 @@ static void *run(void *arg) grep_source_clear_data(&w->source); work_done(w); } - free_grep_patterns(arg); - free(arg); + free_grep_patterns(opt); + free(opt); return (void*) (intptr_t) hit; } |