summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2016-02-25 09:21:12 -0500
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-02-25 11:32:41 -0800
commita1283866bab1cd12da57b3e427664180f5dee333 (patch)
tree9089dd1ca5e644b0db7dcb959e856846e7ea9a0d /builtin
parentGit 2.4.10 (diff)
downloadtgif-a1283866bab1cd12da57b3e427664180f5dee333.tar.xz
t5313: test bounds-checks of corrupted/malicious pack/idx files
Our on-disk .pack and .idx files may reference other data by offset. We should make sure that we are not fooled by corrupt data into accessing memory outside of our mmap'd boundaries. This patch adds a series of tests for offsets found in .pack and .idx files. For the most part we get this right, but there are two tests of .idx files marked as failures: we do not bounds-check offsets in the v2 index's extended offset table, nor do we handle .idx offsets that overflow a signed off_t. With these tests, we should have good coverage of all offsets found in these files. Note that this doesn't cover .bitmap files, which may have similar bugs. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions