summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Jared Hance <jaredhance@gmail.com>2010-07-31 08:54:55 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2010-08-02 11:53:18 -0700
commit8a883b0260ba7f8d6e4c025ae3c32b454e80ade5 (patch)
tree2c0697d95f057cdb3903053eba8f1dd67876cc2d /builtin
parentgitweb: move highlight config out of guess_file_syntax() (diff)
downloadtgif-8a883b0260ba7f8d6e4c025ae3c32b454e80ade5.tar.xz
builtin/push.c: remove useless temporary variable
Creating a variable nr here to use throughout the function only to change refspec_nr to nr at the end, having not used refspec_nr the entire time, is rather pointless. Instead, simply increment refspec_nr. While at it, use ALLOC_GROW() instead of xrealloc(). Signed-off-by: Jared Hance <jaredhance@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/push.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/builtin/push.c b/builtin/push.c
index f4358b9d23..a2cc9fdea1 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -22,13 +22,13 @@ static int progress;
static const char **refspec;
static int refspec_nr;
+static int refspec_alloc;
static void add_refspec(const char *ref)
{
- int nr = refspec_nr + 1;
- refspec = xrealloc(refspec, nr * sizeof(char *));
- refspec[nr-1] = ref;
- refspec_nr = nr;
+ refspec_nr++;
+ ALLOC_GROW(refspec, refspec_nr, refspec_alloc);
+ refspec[refspec_nr-1] = ref;
}
static void set_refspecs(const char **refs, int nr)