diff options
| author |  Stefan Beller <stefanbeller@gmail.com> | 2014-08-10 23:33:26 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2014-08-12 11:00:33 -0700 |
| commit | 81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c (patch) | |
| tree | 974a155e73dec708825519c9f21a44d678bc86ed /builtin | |
| parent | Git 2.0.4 (diff) | |
| download | tgif-81c3ce3cdce8dffb913243f5b2cc09d9fb966e6c.tar.xz | |
prepare_revision_walk(): check for return value in all places
Even the documentation tells us:
You should check if it returns any error (non-zero return
code) and if it does not, you can start using get_revision()
to do the iteration.
In preparation for this commit, I grepped all occurrences of
prepare_revision_walk and added error messages, when there were none.
Signed-off-by: Stefan Beller <stefanbeller@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/branch.c | 4 | ||||
| -rw-r--r-- | builtin/commit.c | 3 |
2 files changed, 5 insertions, 2 deletions
diff --git a/builtin/branch.c b/builtin/branch.c index 652b1d2d14..e91ecc6fbd 100644 --- a/builtin/branch.c +++ b/builtin/branch.c @@ -653,7 +653,9 @@ static int print_ref_list(int kinds, int detached, int verbose, int abbrev, stru add_pending_object(&ref_list.revs, (struct object *) filter, ""); ref_list.revs.limited = 1; - prepare_revision_walk(&ref_list.revs); + + if (prepare_revision_walk(&ref_list.revs)) + die(_("revision walk setup failed")); if (verbose) ref_list.maxwidth = calc_maxwidth(&ref_list); } diff --git a/builtin/commit.c b/builtin/commit.c index 39cf8976e3..447ded63fd 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -989,7 +989,8 @@ static const char *find_author_by_nickname(const char *name) revs.mailmap = &mailmap; read_mailmap(revs.mailmap, NULL); - prepare_revision_walk(&revs); + if (prepare_revision_walk(&revs)) + die(_("revision walk setup failed")); commit = get_revision(&revs); if (commit) { struct pretty_print_context ctx = {0}; |