diff options
| author |  Tanushree Tumane <tanushreetumane@gmail.com> | 2019-12-14 09:11:24 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-12-17 14:55:36 -0800 |
| commit | 7c5cea7242b5c01fdfe006441e5c0b480603f966 (patch) | |
| tree | bb2a2eed376d95cbb041106ce615cb879863f580 /builtin | |
| parent | Git 2.24.1 (diff) | |
| download | tgif-7c5cea7242b5c01fdfe006441e5c0b480603f966.tar.xz | |
bisect--helper: convert `*_warning` char pointers to char arrays.
Instead of using a pointer that points at a constant string,
just give name directly to the constant string; this way, we
do not have to allocate a pointer variable in addition to
the string we want to use.
Let's convert `need_bad_and_good_revision_warning` and
`need_bisect_start_warning` char pointers to char arrays.
Mentored-by: Christian Couder <chriscool@tuxfamily.org>
Signed-off-by: Tanushree Tumane <tanushreetumane@gmail.com>
Signed-off-by: Miriam Rubio <mirucam@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/bisect--helper.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c index 1fbe156e67..96f1c2d1d2 100644 --- a/builtin/bisect--helper.c +++ b/builtin/bisect--helper.c @@ -281,11 +281,11 @@ static int mark_good(const char *refname, const struct object_id *oid, return 1; } -static const char *need_bad_and_good_revision_warning = +static const char need_bad_and_good_revision_warning[] = N_("You need to give me at least one %s and %s revision.\n" "You can use \"git bisect %s\" and \"git bisect %s\" for that."); -static const char *need_bisect_start_warning = +static const char need_bisect_start_warning[] = N_("You need to start by \"git bisect start\".\n" "You then need to give me at least one %s and %s revision.\n" "You can use \"git bisect %s\" and \"git bisect %s\" for that."); |