diff options
| author |  Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-03-28 15:15:47 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2021-03-28 19:03:10 -0700 |
| commit | 53692df2b82f9d5ce15779da7d5227f1b027e193 (patch) | |
| tree | 98ee5b34e115f23fe359052b371c2b28a3979e3a /builtin | |
| parent | fsck.c: pass along the fsck_msg_id in the fsck_error callback (diff) | |
| download | tgif-53692df2b82f9d5ce15779da7d5227f1b027e193.tar.xz | |
fsck.c: add an fsck_set_msg_type() API that takes enums
Change code I added in acf9de4c94e (mktag: use fsck instead of custom
verify_tag(), 2021-01-05) to make use of a new API function that takes
the fsck_msg_{id,type} types, instead of arbitrary strings that
we'll (hopefully) parse into those types.
At the time that the fsck_set_msg_type() API was introduced in
0282f4dced0 (fsck: offer a function to demote fsck errors to warnings,
2015-06-22) it was only intended to be used to parse user-supplied
data.
For things that are purely internal to the C code it makes sense to
have the compiler check these arguments, and to skip the sanity
checking of the data in fsck_set_msg_type() which is redundant to
checks we get from the compiler.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/mktag.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin/mktag.c b/builtin/mktag.c index 96e63bc772..dddcccdd36 100644 --- a/builtin/mktag.c +++ b/builtin/mktag.c @@ -88,7 +88,8 @@ int cmd_mktag(int argc, const char **argv, const char *prefix) die_errno(_("could not read from stdin")); fsck_options.error_func = mktag_fsck_error_func; - fsck_set_msg_type(&fsck_options, "extraheaderentry", "warn"); + fsck_set_msg_type_from_ids(&fsck_options, FSCK_MSG_EXTRA_HEADER_ENTRY, + FSCK_WARN); /* config might set fsck.extraHeaderEntry=* again */ git_config(git_fsck_config, &fsck_options); if (fsck_tag_standalone(NULL, buf.buf, buf.len, &fsck_options, |