diff options
| author |  Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2018-05-19 07:28:28 +0200 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2018-05-21 14:07:20 +0900 |
| commit | 44cecbf8a02921a60eb6f7461f6877329edc8a0d (patch) | |
| tree | 698f2a8e35091b64a9b626836f10c546bd1c1a56 /builtin | |
| parent | show-branch: use commit-slab for commit-name instead of commit->util (diff) | |
| download | tgif-44cecbf8a02921a60eb6f7461f6877329edc8a0d.tar.xz | |
show-branch: note about its object flags usage
This is another candidate for commit-slab. Keep Junio's observation in
code so we can search it later on when somebody wants to improve the
code.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/show-branch.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/builtin/show-branch.c b/builtin/show-branch.c index 29d15d16d2..f2e985c00a 100644 --- a/builtin/show-branch.c +++ b/builtin/show-branch.c @@ -22,6 +22,11 @@ static int showbranch_use_color = -1; static struct argv_array default_args = ARGV_ARRAY_INIT; +/* + * TODO: convert this use of commit->object.flags to commit-slab + * instead to store a pointer to ref name directly. Then use the same + * UNINTERESTING definition from revision.h here. + */ #define UNINTERESTING 01 #define REV_SHIFT 2 |