summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2021-10-12 13:51:38 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-10-12 13:51:38 -0700
commit444b8548b1bb8cec8fc885455eba2e0efcca780f (patch)
tree5cabfec2e9a20c65fe3289218e8a7b005f749889 /builtin
parentMerge branch 'jk/range-diff-fixes' into maint (diff)
parentcommit: restore --edit when combined with --fixup (diff)
downloadtgif-444b8548b1bb8cec8fc885455eba2e0efcca780f.tar.xz
Merge branch 'jk/commit-edit-fixup-fix' into maint
"git commit --fixup" now works with "--edit" again, after it was broken in v2.32. * jk/commit-edit-fixup-fix: commit: restore --edit when combined with --fixup
Diffstat (limited to 'builtin')
-rw-r--r--builtin/commit.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/builtin/commit.c b/builtin/commit.c
index 243c626307..7c9b1e7be3 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -1253,8 +1253,6 @@ static int parse_and_validate_options(int argc, const char *argv[],
if (logfile || have_option_m || use_message)
use_editor = 0;
- if (0 <= edit_flag)
- use_editor = edit_flag;
/* Sanity check options */
if (amend && !current_head)
@@ -1344,6 +1342,9 @@ static int parse_and_validate_options(int argc, const char *argv[],
}
}
+ if (0 <= edit_flag)
+ use_editor = edit_flag;
+
cleanup_mode = get_cleanup_mode(cleanup_arg, use_editor);
handle_untracked_files_arg(s);