summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2014-06-24 05:45:46 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2014-06-25 15:27:24 -0700
commit28bf9429ef2e1534be8d3a59ad236834be542b86 (patch)
tree29036aa31a53372b6b37bb2b0ad57a04a2f7f816 /builtin
parentreplace: replace spaces with tabs in indentation (diff)
downloadtgif-28bf9429ef2e1534be8d3a59ad236834be542b86.tar.xz
avoid double close of descriptors handed to run_command
When a file descriptor is given to run_command via the "in", "out", or "err" parameters, run_command takes ownership. The descriptor will be closed in the parent process whether the process is spawned successfully or not, and closing it again is wrong. In practice this has not caused problems, because we usually close() right after start_command returns, meaning no other code has opened a descriptor in the meantime. So we just get EBADF and ignore it (rather than accidentally closing somebody else's descriptor!). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/replace.c2
1 files changed, 0 insertions, 2 deletions
diff --git a/builtin/replace.c b/builtin/replace.c
index 8507835d39..eb1d2ec5e5 100644
--- a/builtin/replace.c
+++ b/builtin/replace.c
@@ -207,8 +207,6 @@ static void export_object(const unsigned char *sha1, const char *filename)
if (run_command(&cmd))
die("cat-file reported failure");
-
- close(fd);
}
/*