summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorLibravatar Taylor Blau <me@ttaylorr.com>2020-09-09 11:22:50 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2020-09-09 12:51:48 -0700
commit025d52943e89ad01791bb5c4db106b87ebfe3889 (patch)
tree1d8e6668007692963e37d1dd68719674e0eea8e1 /builtin
parentcommit-graph: introduce 'get_bloom_filter_settings()' (diff)
downloadtgif-025d52943e89ad01791bb5c4db106b87ebfe3889.tar.xz
t4216: use an '&&'-chain
In a759bfa9ee (t4216: add end to end tests for git log with Bloom filters, 2020-04-06), a 'rm' invocation was added without a corresponding '&&' chain. When 'trace.perf' already exists, everything works fine. However, the function can be executed without 'trace.perf' on disk (eg., when the subset of tests run is altered with '--run'), and so the bare 'rm' complains about a missing file. To remove some noise from the test log, invoke 'rm' with '-f', at which point it is sensible to place the 'rm -f' in an '&&'-chain, which is both (1) our usual style, and (2) avoids a broken chain in the future if more commands are added at the beginning of the function. Helped-by: Eric Sunshine <sunshine@sunshineco.com> Helped-by: Jeff King <peff@peff.net> Signed-off-by: Taylor Blau <me@ttaylorr.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions