diff options
| author |  Jeff King <peff@peff.net> | 2013-10-24 04:53:01 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2013-10-24 15:43:50 -0700 |
| commit | 0064053bd76ba385e1b5d51b6175bc17bc507804 (patch) | |
| tree | 50da5cf8b850762e6219618292a14941fd163e2f /builtin | |
| parent | log_tree_diff: die when we fail to parse a commit (diff) | |
| download | tgif-0064053bd76ba385e1b5d51b6175bc17bc507804.tar.xz | |
assume parse_commit checks commit->object.parsed
The parse_commit function will check the "parsed" flag of
the object and do nothing if it is set. There is no need
for callers to check the flag themselves, and doing so only
clutters the code.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/blame.c | 3 | ||||
| -rw-r--r-- | builtin/name-rev.c | 3 | ||||
| -rw-r--r-- | builtin/show-branch.c | 3 |
3 files changed, 3 insertions, 6 deletions
diff --git a/builtin/blame.c b/builtin/blame.c index 079dcd3407..4d25466509 100644 --- a/builtin/blame.c +++ b/builtin/blame.c @@ -1554,8 +1554,7 @@ static void assign_blame(struct scoreboard *sb, int opt) */ origin_incref(suspect); commit = suspect->commit; - if (!commit->object.parsed) - parse_commit(commit); + parse_commit(commit); if (reverse || (!(commit->object.flags & UNINTERESTING) && !(revs->max_age != -1 && commit->date < revs->max_age))) diff --git a/builtin/name-rev.c b/builtin/name-rev.c index 0aaa19e4ab..26f40330e3 100644 --- a/builtin/name-rev.c +++ b/builtin/name-rev.c @@ -27,8 +27,7 @@ static void name_rev(struct commit *commit, struct commit_list *parents; int parent_number = 1; - if (!commit->object.parsed) - parse_commit(commit); + parse_commit(commit); if (commit->date < cutoff) return; diff --git a/builtin/show-branch.c b/builtin/show-branch.c index 9788eb115b..3afc79b2c3 100644 --- a/builtin/show-branch.c +++ b/builtin/show-branch.c @@ -227,8 +227,7 @@ static void join_revs(struct commit_list **list_p, parents = parents->next; if ((this_flag & flags) == flags) continue; - if (!p->object.parsed) - parse_commit(p); + parse_commit(p); if (mark_seen(p, seen_p) && !still_interesting) extra--; p->object.flags |= flags; |