summaryrefslogtreecommitdiff
path: root/builtin/verify-pack.c
diff options
context:
space:
mode:
authorLibravatar Ævar Arnfjörð Bjarmason <avarab@gmail.com>2021-10-16 11:39:23 +0200
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-10-16 11:17:04 -0700
commited90f04155df1ec757b241ae3f45889c05efae26 (patch)
treec9d58e7acc1966c43c79ce9e24b8f12a3e185f0c /builtin/verify-pack.c
parentrefs API: make refs_ref_exists() not set errno (diff)
downloadtgif-ed90f04155df1ec757b241ae3f45889c05efae26.tar.xz
refs API: make resolve_ref_unsafe() not set errno
Change the resolve_ref_unsafe() wrapper function to use the underlying refs_werrres_ref_unsafe() directly. From a reading of the callers I determined that the only one who cared about errno was a sequencer.c caller added in e47c6cafcb5 (commit: move print_commit_summary() to libgit, 2017-11-24), I'm migrating it to using refs_werrres_ref_unsafe() directly. This adds another "set errno" instance, but in this case it's OK and idiomatic. We are setting it just before calling die_errno(). We could have some hypothetical die_errno_var(&saved_errno, ...) here, but I don't think it's worth it. The problem with errno is subtle action at distance, not this sort of thing. We already use this pattern in a couple of places in wrapper.c Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/verify-pack.c')
0 files changed, 0 insertions, 0 deletions