diff options
author | Jeff King <peff@peff.net> | 2017-09-21 02:23:24 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-09-22 12:49:55 +0900 |
commit | d0e9983980a25e0c398cc03342e5ad22ef85b8a8 (patch) | |
tree | 24205669b7ed2d0d34b20e28c4d06e3d93a773fa /builtin/submodule--helper.c | |
parent | test-line-buffer: simplify command parsing (diff) | |
download | tgif-d0e9983980a25e0c398cc03342e5ad22ef85b8a8.tar.xz |
curl_trace(): eliminate switch fallthrough
Our trace handler is called by curl with a curl_infotype
variable to interpret its data field. For most types we
print the data and then break out of the switch. But for
CURLINFO_TEXT, we print data and then fall through to the
"default" case, which does the exact same thing (nothing!)
that breaking out of the switch would.
This is probably a leftover from an early iteration of the
patch where the code after the switch _did_ do something
interesting that was unique to the non-text case arms.
But in its current form, this fallthrough is merely
confusing (and causes gcc's -Wimplicit-fallthrough to
complain).
Let's make CURLINFO_TEXT like the other case arms, and push
the default arm to the end where it's more obviously a
catch-all.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/submodule--helper.c')
0 files changed, 0 insertions, 0 deletions