diff options
| author |  Jonathan Nieder <jrnieder@gmail.com> | 2019-12-05 01:28:28 -0800 |
|---|---|---|
| committer |  Johannes Schindelin <johannes.schindelin@gmx.de> | 2019-12-06 16:30:50 +0100 |
| commit | c1547450748fcbac21675f2681506d2d80351a19 (patch) | |
| tree | 6ef2c057f075f77f6e9f5d0c2ce1e49857add929 /builtin/submodule--helper.c | |
| parent | t7415: adjust test for dubiously-nested submodule gitdirs for v2.20.x (diff) | |
| download | tgif-c1547450748fcbac21675f2681506d2d80351a19.tar.xz | |
submodule: defend against submodule.update = !command in .gitmodules
In v2.15.4, we started to reject `submodule.update` settings in
`.gitmodules`. Let's raise a BUG if it somehow still made it through
from anywhere but the Git config.
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Diffstat (limited to 'builtin/submodule--helper.c')
| -rw-r--r-- | builtin/submodule--helper.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c index b93d624a85..f26bdace0b 100644 --- a/builtin/submodule--helper.c +++ b/builtin/submodule--helper.c @@ -1482,6 +1482,8 @@ static void determine_submodule_update_strategy(struct repository *r, die(_("Invalid update mode '%s' configured for submodule path '%s'"), val, path); } else if (sub->update_strategy.type != SM_UPDATE_UNSPECIFIED) { + if (sub->update_strategy.type == SM_UPDATE_COMMAND) + BUG("how did we read update = !command from .gitmodules?"); out->type = sub->update_strategy.type; out->command = sub->update_strategy.command; } else |