summaryrefslogtreecommitdiff
path: root/builtin/show-ref.c
diff options
context:
space:
mode:
authorLibravatar Charles Bailey <cbailey32@bloomberg.net>2015-06-22 14:53:29 +0100
committerLibravatar Junio C Hamano <gitster@pobox.com>2015-06-22 15:29:51 -0700
commitd417c244ec72f7300478fce035c5e49bfdc07537 (patch)
tree074d5bce2abede70b5e76cac97dce365d8f80ef0 /builtin/show-ref.c
parentcontrib/subtree: use tabs consitently for indentation in tests (diff)
downloadtgif-d417c244ec72f7300478fce035c5e49bfdc07537.tar.xz
contrib/subtree: fix broken &&-chains and revealed test error
This fixes two instances where a &&-chain was broken in the subtree tests and fixes a test error that was revealed because of this. Many tests in t7900-subtree.sh make a commit and then use 'undo' to reset the state for the next test. In the 'check hash of split' test, an 'undo' was being invoked after a 'subtree split' even though the particular invocation of 'subtree split' did not actually make a commit. The subsequent check_equal was failing, but this failure was masked by that broken &&-chain. Removing this undo causes the failing check_equal to succeed but breaks the a check_equal later on in the same test. It turns out that an earlier test ('check if --message for merge works with squash too') makes a commit but doesn't 'undo' to the state expected by the remaining tests. None of the intervening tests cared enough about the state of the test repo to fail and the spurious 'undo' in 'check hash of split' restored the expected state for any remaining test that might care. Adding the missing 'undo' to 'check if --message for merge works with squash too' and removing the spurious one from 'check hash of split' fixes all tests once the &&-chains are completed. Signed-off-by: Charles Bailey <cbailey32@bloomberg.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/show-ref.c')
0 files changed, 0 insertions, 0 deletions