diff options
author | Jeff King <peff@peff.net> | 2017-05-31 00:27:47 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2017-06-01 09:59:00 +0900 |
commit | a56eea28c45a8f76e4167c4e6baa87e89b7be3bc (patch) | |
tree | ec7d632c2fc3c136147aae12ce14d270d1931c5a /builtin/remote.c | |
parent | Git 2.13 (diff) | |
download | tgif-a56eea28c45a8f76e4167c4e6baa87e89b7be3bc.tar.xz |
remote: drop free_refspecs() function
We already have free_refspec(), a public function which does
the same thing as the static free_refspecs(). Let's just
keep one. There are two minor differences between the
functions:
1. free_refspecs() is a noop when the refspec argument is
NULL. This probably doesn't matter in practice. The
nr_refspec parameter would presumably be 0 in that
case, skipping the loop. And free(NULL) is explicitly
OK. But it doesn't hurt for us to port this extra
safety to free_refspec(), as one of the callers passes
a funny "i+1" count.
2. The order of arguments is reversed between the two
functions. This patch uses the already-public order of
free_refspec(), as it matches the argument order on the
parsing side.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/remote.c')
0 files changed, 0 insertions, 0 deletions