diff options
author | Luke Diamand <luke@diamand.org> | 2015-06-10 08:30:59 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2015-06-10 08:29:17 -0700 |
commit | 1051ef00636357061d72bcf673da86054fb14a12 (patch) | |
tree | b22a0deb0f67a6249a57b4003b0e8e3287f8782b /builtin/remote-ext.c | |
parent | git-p4: add tests for non-numeric revision range (diff) | |
download | tgif-1051ef00636357061d72bcf673da86054fb14a12.tar.xz |
git-p4: fixing --changes-block-size handling
The --changes-block-size handling was intended to help when
a user has a limited "maxscanrows" (see "p4 group"). It used
"p4 changes -m $maxchanges" to limit the number of results.
Unfortunately, it turns out that the "maxscanrows" and "maxresults"
limits are actually applied *before* the "-m maxchanges" parameter
is considered (experimentally).
Fix the block-size handling so that it gets blocks of changes
limited by revision number ($Start..$Start+$N, etc). This limits
the number of results early enough that both sets of tests pass.
Note that many other Perforce operations can fail for the same
reason (p4 print, p4 files, etc) and it's probably not possible
to workaround this. In the real world, this is probably not
usually a problem.
Signed-off-by: Luke Diamand <luke@diamand.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/remote-ext.c')
0 files changed, 0 insertions, 0 deletions