diff options
author | René Scharfe <rene.scharfe@lsrfire.ath.cx> | 2013-01-08 21:23:01 +0100 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-01-08 13:18:49 -0800 |
commit | 283b365e4521082ab37d93762bb2f049dc38bee8 (patch) | |
tree | c19408667e40336a780a88606dd87fa915040b51 /builtin/reflog.c | |
parent | Merge branch 'ms/subtree-fixlets' into maint (diff) | |
download | tgif-283b365e4521082ab37d93762bb2f049dc38bee8.tar.xz |
t1402: work around shell quoting issue on NetBSD
The test fails for me on NetBSD 6.0.1 and reports:
ok 1 - ref name '' is invalid
ok 2 - ref name '/' is invalid
ok 3 - ref name '/' is invalid with options --allow-onelevel
ok 4 - ref name '/' is invalid with options --normalize
error: bug in the test script: not 2 or 3 parameters to test-expect-success
The alleged bug is in this line:
invalid_ref NOT_MINGW '/' '--allow-onelevel --normalize'
invalid_ref() constructs a test case description using its last argument,
but the shell seems to split it up into two pieces if it contains a
space. Minimal test case:
# on NetBSD with /bin/sh
$ a() { echo $#-$1-$2; }
$ t="x"; a "${t:+$t}"
1-x-
$ t="x y"; a "${t:+$t}"
2-x-y
$ t="x y"; a "${t:+x y}"
1-x y-
# and with bash
$ t="x y"; a "${t:+$t}"
1-x y-
$ t="x y"; a "${t:+x y}"
1-x y-
This may be a bug in the shell, but here's a simple workaround: Construct
the description string first and store it in a variable, and then use
that to call test_expect_success().
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/reflog.c')
0 files changed, 0 insertions, 0 deletions