summaryrefslogtreecommitdiff
path: root/builtin/receive-pack.c
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2022-02-05 09:42:29 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2022-02-05 09:42:29 -0800
commit492261a6def32669ddea7103ceb4d18c9b80903f (patch)
tree0671872002d2bf49d3094c966a588de16e72a4e6 /builtin/receive-pack.c
parentMerge branch 'pb/pull-rebase-autostash-fix' (diff)
parentreceive-pack.c: consolidate find header logic (diff)
downloadtgif-492261a6def32669ddea7103ceb4d18c9b80903f.tar.xz
Merge branch 'jc/find-header'
Code clean-up. * jc/find-header: receive-pack.c: consolidate find header logic
Diffstat (limited to 'builtin/receive-pack.c')
-rw-r--r--builtin/receive-pack.c33
1 files changed, 10 insertions, 23 deletions
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index 9f4a0b816c..5c2732a0d0 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -581,32 +581,19 @@ static char *prepare_push_cert_nonce(const char *path, timestamp_t stamp)
return strbuf_detach(&buf, NULL);
}
-/*
- * NEEDSWORK: reuse find_commit_header() from jk/commit-author-parsing
- * after dropping "_commit" from its name and possibly moving it out
- * of commit.c
- */
static char *find_header(const char *msg, size_t len, const char *key,
const char **next_line)
{
- int key_len = strlen(key);
- const char *line = msg;
-
- while (line && line < msg + len) {
- const char *eol = strchrnul(line, '\n');
-
- if ((msg + len <= eol) || line == eol)
- return NULL;
- if (line + key_len < eol &&
- !memcmp(line, key, key_len) && line[key_len] == ' ') {
- int offset = key_len + 1;
- if (next_line)
- *next_line = *eol ? eol + 1 : eol;
- return xmemdupz(line + offset, (eol - line) - offset);
- }
- line = *eol ? eol + 1 : NULL;
- }
- return NULL;
+ size_t out_len;
+ const char *val = find_header_mem(msg, len, key, &out_len);
+
+ if (!val)
+ return NULL;
+
+ if (next_line)
+ *next_line = val + out_len + 1;
+
+ return xmemdupz(val, out_len);
}
/*