diff options
author | Jeff King <peff@peff.net> | 2018-11-12 09:55:58 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-11-13 14:22:03 +0900 |
commit | 97b2fa08b6b9ee3ebd927bbc208bf5223e5ac849 (patch) | |
tree | dd77ba74f97fa24cc18f7f4da9526125caca8233 /builtin/rebase.c | |
parent | sha1-file: use loose object cache for quick existence check (diff) | |
download | tgif-97b2fa08b6b9ee3ebd927bbc208bf5223e5ac849.tar.xz |
fetch-pack: drop custom loose object cache
Commit 024aa4696c (fetch-pack.c: use oidset to check existence of loose
object, 2018-03-14) added a cache to avoid calling stat() for a bunch of
loose objects we don't have.
Now that OBJECT_INFO_QUICK handles this caching itself, we can drop the
custom solution.
Note that this might perform slightly differently, as the original code
stopped calling readdir() when we saw more loose objects than there were
refs. So:
1. The old code might have spent work on readdir() to fill the cache,
but then decided there were too many loose objects, wasting that
effort.
2. The new code might spend a lot of time on readdir() if you have a
lot of loose objects, even though there are very few objects to
ask about.
In practice it probably won't matter either way; see the previous commit
for some discussion of the tradeoff.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rebase.c')
0 files changed, 0 insertions, 0 deletions