diff options
| author |  Denton Liu <liu.denton@gmail.com> | 2019-12-06 12:16:31 -0800 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-12-06 12:36:53 -0800 |
| commit | abcf8573005d548fe213aa7b4579394fa18692a1 (patch) | |
| tree | 48458508a39252cb7e52dcfc84d49a33adef5d3c /builtin/range-diff.c | |
| parent | range-diff: mark pointers as const (diff) | |
| download | tgif-abcf8573005d548fe213aa7b4579394fa18692a1.tar.xz | |
range-diff: clear `other_arg` at end of function
We were leaking memory by not clearing `other_arg` after we were done
using it. Clear it after we've finished using it.
Note that this isn't strictly necessary since the memory will be
reclaimed once the command exits. However, since we are releasing the
strbufs, we should also clear `other_arg` for consistency.
Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/range-diff.c')
| -rw-r--r-- | builtin/range-diff.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/range-diff.c b/builtin/range-diff.c index 98acf3533e..d8a4670629 100644 --- a/builtin/range-diff.c +++ b/builtin/range-diff.c @@ -84,6 +84,7 @@ int cmd_range_diff(int argc, const char **argv, const char *prefix) res = show_range_diff(range1.buf, range2.buf, creation_factor, simple_color < 1, &diffopt, &other_arg); + argv_array_clear(&other_arg); strbuf_release(&range1); strbuf_release(&range2); |