summaryrefslogtreecommitdiff
path: root/builtin/push.c
diff options
context:
space:
mode:
authorLibravatar Junio C Hamano <gitster@pobox.com>2021-02-25 16:43:32 -0800
committerLibravatar Junio C Hamano <gitster@pobox.com>2021-02-25 16:43:33 -0800
commit140045821aa78da3a80a7d7c8f707b955e1ab40d (patch)
tree9a8bb3c516eb72c8a5141dd3c162e3dc2d34d186 /builtin/push.c
parentMerge branch 'sh/mergetools-vimdiff1' (diff)
parentpush: do not turn --delete '' into a matching push (diff)
downloadtgif-140045821aa78da3a80a7d7c8f707b955e1ab40d.tar.xz
Merge branch 'jc/push-delete-nothing'
"git push $there --delete ''" should have been diagnosed as an error, but instead turned into a matching push, which has been corrected. * jc/push-delete-nothing: push: do not turn --delete '' into a matching push
Diffstat (limited to 'builtin/push.c')
-rw-r--r--builtin/push.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/push.c b/builtin/push.c
index 03adb58602..194967ed79 100644
--- a/builtin/push.c
+++ b/builtin/push.c
@@ -115,7 +115,7 @@ static void set_refspecs(const char **refs, int nr, const char *repo)
else
refspec_appendf(&rs, "refs/tags/%s", ref);
} else if (deleterefs) {
- if (strchr(ref, ':'))
+ if (strchr(ref, ':') || !*ref)
die(_("--delete only accepts plain target ref names"));
refspec_appendf(&rs, ":%s", ref);
} else if (!strchr(ref, ':')) {