summaryrefslogtreecommitdiff
path: root/builtin/pull.c
diff options
context:
space:
mode:
authorLibravatar Jeff King <peff@peff.net>2016-06-17 19:38:55 -0400
committerLibravatar Junio C Hamano <gitster@pobox.com>2016-06-17 17:03:57 -0700
commit0581b546419627d4e82f7df8b195fa207ef42f6a (patch)
tree25e43e9f84f459d04051da6d35efc8b18e8c59b3 /builtin/pull.c
parentverify_signed_buffer: use pipe_command (diff)
downloadtgif-0581b546419627d4e82f7df8b195fa207ef42f6a.tar.xz
sign_buffer: use pipe_command
Similar to the prior commit for verify_signed_buffer, the motivation here is both to make the code simpler, and to avoid any possible deadlocks with gpg. In this case we have the same "write to stdin, then read from stdout" that the verify case had. This is unlikely to be a problem in practice, since stdout has the detached signature, which it cannot compute until it has read all of stdin (if it were a non-detached signature, that would be a problem, though). We don't read from stderr at all currently. However, we will want to in a future patch, so this also prepares us there (and in that case gpg _does_ write before reading all of the input, though again, it is unlikely that a key uid will fill up a pipe buffer). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/pull.c')
0 files changed, 0 insertions, 0 deletions