diff options
author | Thomas Rast <trast@inf.ethz.ch> | 2013-06-20 18:38:28 -0400 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-06-20 15:51:35 -0700 |
commit | b4dc085a8dc2ec2fb5f6366fa672222b807ed655 (patch) | |
tree | 980f8140e6055383ed1ddfa7de86085b7a6e9462 /builtin/pack-objects.c | |
parent | pull: update unborn branch tip after index (diff) | |
download | tgif-b4dc085a8dc2ec2fb5f6366fa672222b807ed655.tar.xz |
pull: merge into unborn by fast-forwarding from empty tree
The logic for pulling into an unborn branch was originally
designed to be used on a newly-initialized repository
(d09e79c, git-pull: allow pulling into an empty repository,
2006-11-16). It thus did not initially deal with
uncommitted changes in the unborn branch. The case of an
_unstaged_ untracked file was fixed by 4b3ffe5 (pull: do not
clobber untracked files on initial pull, 2011-03-25).
However, it still clobbered existing staged files, both when
the file exists in the merged commit (it will be
overwritten), and when it does not (it will be deleted).
We fix this by doing a two-way merge, where the "current"
side of the merge is an empty tree, and the "target" side is
HEAD (already updated to FETCH_HEAD at this point). This
amounts to claiming that all work in the index was done vs.
an empty tree, and thus all content of the index is
precious.
Note that this use of read-tree just gives us protection
against overwriting index and working tree changes. It will
not actually result in a 3-way merge conflict in the index.
This is fine, as this is a rare situation, and the conflict
would not be interesting anyway (it must, by definition, be
an add/add conflict with the whole content conflicting). And
it makes it simpler for the user to recover, as they have no
HEAD to "git reset" back to.
Reported-by: Stefan Schüßler <mail@stefanschuessler.de>
Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/pack-objects.c')
0 files changed, 0 insertions, 0 deletions