diff options
| author |  Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-12-07 12:05:51 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2021-12-07 12:31:16 -0800 |
| commit | 5867757d888e690eeafe8d6a68841623c4b8baa8 (patch) | |
| tree | ab8e3fef146e90a0457cb38f2ca5df0ec263d637 /builtin/pack-objects.c | |
| parent | Git 2.34.1 (diff) | |
| download | tgif-5867757d888e690eeafe8d6a68841623c4b8baa8.tar.xz | |
pack-objects: use BUG(...) not die("BUG: ...")
Change this code added in da93d12b004 (pack-objects: be incredibly
anal about stdio semantics, 2006-04-02) to use BUG() instead.
See 1a07e59c3e2 (Update messages in preparation for i18n, 2018-07-21)
for when the "BUG: " prefix was added, and [1] for background on the
Solaris behavior that prompted the exhaustive error checking in this
fgets() loop.
1. https://lore.kernel.org/git/824.1144007555@lotus.CS.Berkeley.EDU/
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/pack-objects.c')
| -rw-r--r-- | builtin/pack-objects.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c index 1a3dd445f8..0b1f82cd3a 100644 --- a/builtin/pack-objects.c +++ b/builtin/pack-objects.c @@ -3397,7 +3397,7 @@ static void read_object_list_from_stdin(void) if (feof(stdin)) break; if (!ferror(stdin)) - die("BUG: fgets returned NULL, not EOF, not error!"); + BUG("fgets returned NULL, not EOF, not error!"); if (errno != EINTR) die_errno("fgets"); clearerr(stdin); |