diff options
| author |  Doan Tran Cong Danh <congdanhqx@gmail.com> | 2019-10-16 12:18:41 +0700 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2019-10-18 09:43:10 +0900 |
| commit | d58deb9c4e151d4d8380cd14223391ce0d58f588 (patch) | |
| tree | df6b2fcfe848eaeb41160b20f082cf8e73c4d3a6 /builtin/notes.c | |
| parent | t3301: test diagnose messages for too few/many paramters (diff) | |
| download | tgif-d58deb9c4e151d4d8380cd14223391ce0d58f588.tar.xz | |
notes: fix minimum number of parameters to "copy" subcommand
The builtin/notes.c::copy() function is prepared to handle either
one or two arguments given from the command line; when one argument
is given, to-obj defaults to HEAD.
bbb1b8a3 ("notes: check number of parameters to "git notes copy"",
2010-06-28) tried to make sure "git notes copy" (with *no* other
argument) does not dereference NULL by checking the number of
parameters, but it incorrectly insisted that we need two arguments,
instead of either one or two. This disabled the defaulting to-obj
to HEAD.
Correct it.
Signed-off-by: Doan Tran Cong Danh <congdanhqx@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/notes.c')
| -rw-r--r-- | builtin/notes.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/notes.c b/builtin/notes.c index 02e97f55c5..95456f3165 100644 --- a/builtin/notes.c +++ b/builtin/notes.c @@ -513,7 +513,7 @@ static int copy(int argc, const char **argv, const char *prefix) } } - if (argc < 2) { + if (argc < 1) { error(_("too few parameters")); usage_with_options(git_notes_copy_usage, options); } |