diff options
author | Junio C Hamano <gitster@pobox.com> | 2018-06-15 11:13:39 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-06-15 11:20:08 -0700 |
commit | 037714252f74ae77e816018e43b2504a1b057246 (patch) | |
tree | b50cad99709711c60d673be889481447226930e3 /builtin/merge-base.c | |
parent | Git 2.17.1 (diff) | |
download | tgif-037714252f74ae77e816018e43b2504a1b057246.tar.xz |
tests: clean after SANITY tests
Some of our tests try to make sure Git behaves sensibly in a
read-only directory, by dropping 'w' permission bit before doing a
test and then restoring it after it is done. The latter is needed
for the test framework to clean after itself without leaving a
leftover directory that cannot be removed.
Ancient parts of tests however arrange the above with
chmod a-w . &&
... do the test ...
status=$?
chmod 775 .
(exit $status)
which obviously would not work if the test somehow dies before it
has the chance to do "chmod 775". Rewrite them by following a more
robust pattern recently written tests use, which is
test_when_finished "chmod 775 ." &&
chmod a-w . &&
... do the test ...
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/merge-base.c')
0 files changed, 0 insertions, 0 deletions