diff options
author | Junio C Hamano <gitster@pobox.com> | 2022-03-03 13:58:39 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2022-03-03 14:00:32 -0800 |
commit | 7b20af6a069f1be1ac0354451e0edd9825b22534 (patch) | |
tree | ab3f2f59a3401bff57c3e536fb6a4c3943326463 /builtin/mailsplit.c | |
parent | Git 2.35.1 (diff) | |
download | tgif-7b20af6a069f1be1ac0354451e0edd9825b22534.tar.xz |
am/apply: warn if we end up reading patches from terminal
In an interactive session, "git am" without arguments, or even
worse, "git am --whitespace file", waits silently for the user to
feed the patches from the standard input (presumably by typing or
copy-pasting). Give a feedback message to the user when this
happens, as it is unlikely that the user meant to do so.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/mailsplit.c')
-rw-r--r-- | builtin/mailsplit.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/builtin/mailsplit.c b/builtin/mailsplit.c index 7baef30569..30952353a3 100644 --- a/builtin/mailsplit.c +++ b/builtin/mailsplit.c @@ -223,6 +223,9 @@ static int split_mbox(const char *file, const char *dir, int allow_bare, FILE *f = !strcmp(file, "-") ? stdin : fopen(file, "r"); int file_done = 0; + if (isatty(fileno(f))) + warning(_("reading patches from stdin/tty...")); + if (!f) { error_errno("cannot open mbox %s", file); goto out; |