diff options
| author |  Martin Ågren <martin.agren@gmail.com> | 2020-11-21 19:31:08 +0100 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-11-21 14:50:33 -0800 |
| commit | 96313423a75fa8d88b6ecd5a15c21a7fbaf9e9be (patch) | |
| tree | 19f731ed362d59f349c88f420ac5d41c0f9acc5e /builtin/log.c | |
| parent | grep: don't set up a "default" repo for grep (diff) | |
| download | tgif-96313423a75fa8d88b6ecd5a15c21a7fbaf9e9be.tar.xz | |
grep: use designated initializers for `grep_defaults`
In 15fabd1bbd ("builtin/grep.c: make configuration callback more
reusable", 2012-10-09), we learned to fill a `static struct grep_opt
grep_defaults` which we can use as a blueprint for other such structs.
At the time, we didn't consider designated initializers to be widely
useable, but these days, we do. (See, e.g., cbc0f81d96 ("strbuf: use
designated initializers in STRBUF_INIT", 2017-07-10).)
Use designated initializers to let the compiler set up the struct and so
that we don't need to remember to call `init_grep_defaults()`.
Signed-off-by: Martin Ågren <martin.agren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/log.c')
| -rw-r--r-- | builtin/log.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/builtin/log.c b/builtin/log.c index eee4beca4d..cf41714fb0 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -131,7 +131,6 @@ static int log_line_range_callback(const struct option *option, const char *arg, static void init_log_defaults(void) { - init_grep_defaults(); init_diff_ui_defaults(); decoration_style = auto_decoration_style(); |