diff options
| author |  Eric Sunshine <sunshine@sunshineco.com> | 2020-09-08 03:16:09 -0400 |
|---|---|---|
| committer |  Junio C Hamano <gitster@pobox.com> | 2020-09-08 15:03:27 -0700 |
| commit | 72a7239016fa4c8919a8b6932ad76e5f820389eb (patch) | |
| tree | 6fe239c7b77ee41d542fb7b3740cde862cd4eca3 /builtin/log.c | |
| parent | diff: move show_interdiff() from its own file to diff-lib (diff) | |
| download | tgif-72a7239016fa4c8919a8b6932ad76e5f820389eb.tar.xz | |
diff-lib: tighten show_interdiff()'s interface
To compute and show an interdiff, show_interdiff() needs only the two
OID's to compare and a diffopts, yet it expects callers to supply an
entire rev_info. The demand for rev_info is not only overkill, but also
places unnecessary burden on potential future callers which might not
otherwise have a rev_info at hand. Address this by tightening its
signature to require only the items it needs instead of a full rev_info.
Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/log.c')
| -rw-r--r-- | builtin/log.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin/log.c b/builtin/log.c index ae9380da1b..37177b3e7f 100644 --- a/builtin/log.c +++ b/builtin/log.c @@ -1206,7 +1206,8 @@ static void make_cover_letter(struct rev_info *rev, int use_stdout, if (rev->idiff_oid1) { fprintf_ln(rev->diffopt.file, "%s", rev->idiff_title); - show_interdiff(rev, 0); + show_interdiff(rev->idiff_oid1, rev->idiff_oid2, 0, + &rev->diffopt); } if (rev->rdiff1) { |