diff options
author | Derrick Stolee <dstolee@microsoft.com> | 2018-11-06 12:34:47 -0800 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2018-11-07 10:49:58 +0900 |
commit | a4544b311eab7c3ffd2aa96deb9be0b92df05ae2 (patch) | |
tree | fa9270e690467af942673231dcb007078caa99b4 /builtin/hash-object.c | |
parent | Git 2.19.1 (diff) | |
download | tgif-a4544b311eab7c3ffd2aa96deb9be0b92df05ae2.tar.xz |
pack-objects: ignore ambiguous object warnings
A git push process runs several processes during its run, but one
includes git send-pack which calls git pack-objects and passes
the known have/wants into stdin using object ids. However, the
default setting for core.warnAmbiguousRefs requires git pack-objects
to check for ref names matching the ref_rev_parse_rules array in
refs.c. This means that every object is triggering at least six
"file exists?" queries. When there are a lot of refs, this can
add up significantly! I observed a simple push spending three
seconds checking these paths.
The fix here is similar to 4c30d50 "rev-list: disable object/refname
ambiguity check with --stdin". While the get_object_list() method
reads the objects from stdin, turn warn_on_object_refname_ambiguity
flag (which is usually true) to false. Just for code hygiene, save
away the original at the beginning and restore it once we are done.
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/hash-object.c')
0 files changed, 0 insertions, 0 deletions