summaryrefslogtreecommitdiff
path: root/builtin/get-tar-commit-id.c
diff options
context:
space:
mode:
authorLibravatar Johannes Schindelin <johannes.schindelin@gmx.de>2019-03-14 04:25:04 -0700
committerLibravatar Junio C Hamano <gitster@pobox.com>2019-03-18 11:44:14 +0900
commit1a85b49b87af0e17a503b94df10d0b39472ad5b8 (patch)
tree134e30676e6d083164858ce3bb7d40b914509f27 /builtin/get-tar-commit-id.c
parentdifftool: remove obsolete (and misleading) comment (diff)
downloadtgif-1a85b49b87af0e17a503b94df10d0b39472ad5b8.tar.xz
parse-options: make OPT_ARGUMENT() more useful
`OPT_ARGUMENT()` is intended to keep the specified long option in `argv` and not to do anything else. However, it would make a lot of sense for the caller to know whether this option was seen at all or not. For example, we want to teach `git difftool` to work outside of any Git worktree, but only when `--no-index` was specified. Note: nothing in Git uses OPT_ARGUMENT(). Even worse, looking through the commit history, one can easily see that nothing even ever used it, apart from the regression test. So not only do we make `OPT_ARGUMENT()` more useful, we are also about to introduce its first real user! Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/get-tar-commit-id.c')
0 files changed, 0 insertions, 0 deletions